Alma: Reqs done - #64
Open
mimyal wants to merge 17 commits into
Open
Conversation
…thod that refers to the method that needed testing
…or method products
…ly have to rework all.all
…th Vendor by_market.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My challenges this week was a) putting tests into the correct class b) over-reliability on copy/paste c) trouble shooting (I feel I have a start in how to go ahead from now) d) trusting old code when new things break. And some more things. Probably, my brain shutting down.
I learnt a few tricks in how minitests work and have a beginner tool kit in what to do when things break and I don't know why. I was very frustrated at not being able to easily test the self.files until I had it explained to me that it is one of the hardest things to test.
Copy/Paste made it hard to TDD because it tricks me to believe I tested the code already.
Copy/Paste was good for forcing in new information. In the same way as they have Kindergarteners chant 10, 20, 30, 40, 50, 60, 70, 80, 90, 100 (!) until even the non-English speakers speak it.
I refactored using enumerables which made my last hour or so quite satisfactory.