Queues - Cara Comfort & Laura Melgarejo - Word-Guess - #8
Open
cecomfort wants to merge 3 commits into
Open
Conversation
droberts-sea
left a comment
There was a problem hiding this comment.
Word-Guess Game
What We're Looking For
| Feature | Feedback |
|---|---|
| Created a Class to encapsulate game functionality. | yes |
| Used methods to DRY up your code. | yes |
| Created instance variables & local variables where appropriate. | yes |
| Used Arrays to store lists of letters guessed. | yes |
| Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. | yes |
| Created interesting ASCII Art. | yes |
| Baseline | |
| Regular Commits with meaningful commit messages. | yes |
| Readable code with consistent indentation. | mostly - see inline comments |
| Created a pull request with your name & a meaningful message. | yes |
| Extras | |
| Used the Colorize Gem. | yes |
| User is not penalized for guessing the same word twice. | yes |
| Multiple difficulty levels. | yes |
| The program can accept the whole word in one guess. | yes |
Program is well-structured and easy to use. Excellent work overall!
|
|
||
| def initialize (word) | ||
| @complete_word = word | ||
| @current_status = generate_dashes |
| require "colorize" | ||
| require 'random_word_generator' | ||
|
|
||
| class Word |
There was a problem hiding this comment.
I like that you've split Word out into a separate class here. This does a good job of separating game logic from the code to display a word, making the whole program more clear.
| end_game | ||
| end | ||
|
|
||
| def make_a_guess |
There was a problem hiding this comment.
Again, watch indentation. I would expect this method to be at the same level as the one above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Word Guess
Congratulations! You're submitting your assignment.
Comprehension Questions