Skip to content

Finished Wave1 and Wave2 - #18

Open
RanaSulaiman wants to merge 1 commit into
Ada-C7:masterfrom
RanaSulaiman:master
Open

Finished Wave1 and Wave2#18
RanaSulaiman wants to merge 1 commit into
Ada-C7:masterfrom
RanaSulaiman:master

Conversation

@RanaSulaiman

@RanaSulaiman RanaSulaiman commented May 18, 2017

Copy link
Copy Markdown

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScrip? the scoreChart object as ruby hash, calling object's properties as accessing values in hashes, converting string to array using split method and instantiating new object from a construct prototype.
What was a challenge you were able to overcome on this assignment? The concept of integrating scrabble object in player prototype.
What is your favorite thing about learning a new programming language? Although it was not easy to google a new syntax, thus I realized that there are lots of similarities between different languages.
What is your least favorite thing about learning a new programming language? Not knowing the power of new language, makes writing the code challenging.
Do you have any recommendations on how we could improve this project for the next cohort?

Comment thread scrabble.js
},

hasWon: function() {
if (this.totalScore() > 100) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also be written: return this.totalScore() > 100;

@CheezItMan

Copy link
Copy Markdown

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Only 1 commit...
Comprehension questions Check, no suggestions for C8 huh.
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Good use of that = this;. Good clean if statements.
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check, good use of highestScoringWord from highestWordScore
Overall Nicely done, neat and well written Javacript. Good use of toUpperCase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants