Theresa's RideShare

[TheresaManney]

Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	A design decision I made was if I should think about edge cases as I create my tests and code or if edge cases should be something I would worry about later. I chose to worry about edge cases later after getting stressed about not being able to finish the project. Even though this was my final decision, in future projects I think at least placing comments of edge case thoughts is a better idea so I don't forget what goals should be focused on at some point.
Describe a concept that you gained more clarity on as you worked on this assignment.	Using enumerals became more obvious to me, although I did not use enumerals all through my code.. I tried to use them where they made best sense to me. Also using :headers in my code and learning how to utilize those commands was a huge learning experience for me.
Describe a nominal test that you wrote for this assignment.	In my drivers specs I checked that exact driver info was gathered when a specific driver_id was searched for in the .find method
Describe an edge case test that you wrote for this assignment.	In the drivers class, .find class method, I made my program raise an argument error if the id was not within the csv file.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I feel I wrote pseudocode well, it definitely helped me organize my thoughts. I'll have to admit, it was very challenging for me to write tests before writing my code. I think writing my psudo code in test type blocks, would help me write tests first (if that makes sense...)

[kariabancroft]

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	Yes - though I think you could use it even more often. Some of your commits include a lot of code changes
Answer comprehension questions	Yes - I like your idea of writing the pseudocode in the tests, that sounds like a good idea
Driver
Uses the all method in the find method	Yes - slick use of the header settings on the CSV reading!
Has appropriate edge-case tests for each method in the class	Almost - opportunity to expand the tests for the trips and average_rating since right now they're covering the basic nominal
Created a method that uses a method from the Trip object to retrieve the list of trips	Yes - note that the classes that are within the module should be able to be referenced without the full module name? Did you try this and have issues leaving the module off?
Created a method that uses the internal trips list to calculate the average rating	Yes - nice use of map and inject enumerable methods here
Rider
Uses the all method in the find method	Yes - find method would be a good opportunity to try out an enumerable method (I know you mentioned this in your comprehension questions)
Has appropriate edge-case tests for each method in the class	Not quite - I think because of the way you've written your tests, you haven't caught some of the issues with your code. Checking that the elements are an Array is a good baseline test, but without checking the contents of that Array you are missing an opportunity to fix a problem.
Created a method that uses a method from the Trip object to retrieve the list of trips	Yes - though I would name this method plural instead of singular since it should return a list
Created a method that uses the internal trips method to retrieve the associated drivers	Yes - though I'm not sure this is actually working correctly. If you call find_many_drivers from the Trip class, I would think that this would give you back Trip objects, not Driver objects. Therefore, I don't think this is the data you expect/desire.
Trip
Reads the CSV file in the all method	Yes
Has appropriate edge-case tests for each method in the class	Mostly there - Nice job trying out let. I'd like to see what would happen the with driver and rider methods if there was any issue with the original data (i.e. these objects didn't exist)
Created a method that uses a method from the Driver to retrieve the associated driver instance	Yes
Created a method that uses a method from the Rider to retrieve the associated rider instance	Yes - nice job using the associated find methods using the instance variable parameters
Created a method to retrieve all trips by driver id	Yes
Created a method to retrieve all trips by rider id	Yes - I'd argue that not finding any drivers or riders is not an argument error. It might be some other kind of issue, but not an argument error. This is another good opportunity to try out an enumerable method.
Overall	I like that I see a require pry in there since its a great tool to use! :-D I think you missed the mark on the trip and driver methods in the Rider class - so it might be worth another look at these two (plus the associated tests).