Brenna's RideShare

[bcmdarroch]

Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I decided to initialize the Driver/Rider/Trip objects with multiple arguments, rather than a single hash. I decided to do it this way because there were only 3 pieces of data for the drivers and riders. I used multiple arguments for trips just to keep it consistent. However, upon reflection, I wish I'd used a hash as the single parameter for each class, because I think it's more readable that way, and the Trip class is a little unwieldy with 5 arguments.
Describe a concept that you gained more clarity on as you worked on this assignment.	I feel more confident using methods within other methods in a class. I also feel like I have a better grasp of using methods to send messages between classes.
Describe a nominal test that you wrote for this assignment.	In trips_spec, under Trip#all, I tested to see if all the trip data from the csv file matched what was in the RideShare::Trip.all method.
Describe an edge case test that you wrote for this assignment.	In trips_spec, under Trip#find_by_driver and #find_by_rider, I checked that an empty array was returned for drivers and riders that didn't exist.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	It took me longer to actually start coding, but I think it helped me make fewer mistakes throughout the process.

[CheezItMan]

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	Regular commits and a reasonable number.
Answer comprehension questions	Check & I'm glad it seemed to help you make fewer mistakes.
Driver
Uses the all method in the find method	Check & Good use of the Enumerable find method.
Has appropriate edge-case tests for each method in the class	Check & nice work
Created a method that uses a method from the Trip object to retrieve the list of trips	Check
Created a method that uses the internal trips list to calculate the average rating	Check, nice use of inject
Rider
Uses the all method in the find method	Check
Has appropriate edge-case tests for each method in the class	Good
Created a method that uses a method from the Trip object to retrieve the list of trips	Check
Created a method that uses the internal trips method to retrieve the associated drivers	Check
Trip
Reads the CSV file in the all method	Check
Has appropriate edge-case tests for each method in the class	Good work here, good use of the CSV in the testing
Created a method that uses a method from the Driver to retrieve the associated driver instance	Check
Created a method that uses a method from the Rider to retrieve the associated rider instance	Check
Created a method to retrieve all trips by driver id	Check
Created a method to retrieve all trips by rider id	Check

Summary

Nice work here. You covered all the requirements. You did a pretty good job of testing as well.