-
Notifications
You must be signed in to change notification settings - Fork 43
First version of the Airborne Software Booklet #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Outdated
Show resolved
Hide resolved
content/booklets/adacore-technologies-for-airborne-software/analysis.rst
Show resolved
Hide resolved
@@ -271,7 +271,7 @@ site-testing: cleantest # | |||
FRONTEND_TESTING=true $(SPHINXBUILD) -M html $(TEST_CONTENT) \ | |||
"$(TEST_BUILDDIR)" $(SPHINXOPTS) $(O) -v -c "$(SPHINXCONF)" | |||
|
|||
BOOKS = $(wildcard $(CONTENT_DIR)/courses/*/.) $(wildcard $(CONTENT_DIR)/labs/*/.) | |||
BOOKS = $(wildcard $(CONTENT_DIR)/courses/*/.) $(wildcard $(CONTENT_DIR)/labs/*/.) $(wildcard $(CONTENT_DIR)/booklets/*/.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed now that this has been added to a new category called "booklets". Many years ago, we made the decision to remove the distinction between courses and books (or booklets) and call everything courses. In fact, other booklets — such as the "Ada for the C++ or Java Developer" booklet — have been adapted to fit the course format. I'd prefer not introducing a new category at this point in time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of location in the repo, I am ok to move this new content in the courses
dir.
As far as the presentation on the home page, I'd like to keep this book and the upcoming railway and space ones separated in the "AdaCore Technology Booklets" category.
@@ -184,6 +184,13 @@ def get_file_from_conf_ini(path_to_file): | |||
# The name of the Pygments (syntax highlighting) style to use. | |||
pygments_style = 'sphinx' | |||
|
|||
# Figures, tables and code-blocks are automatically numbered if they | |||
# have a caption. | |||
numfig = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, this addition should be OK, but I'll evaluate the impact on the PDF version of other courses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of general comments in the review.
Just as an offer, I could work on a couple of the adaptations that I'm suggesting / requesting in the comments. Just let me know!
Thanks @gusthoff , I made a first pass and I will continue next week. |
No description provided.