[trello.com/c/sG80IZan] fix reading while TransactionDetails on screen #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lainaaa
reviewed
Apr 30, 2025
There was a problem hiding this comment.
I think it should work, however this code will be harder to maintenance because devs have to keep in mind to update this code when they would want to add new screen above the chat.
Instead, what about just checking if the current screen is on the top of the navigation stack?
its now working on MacOS because of split view |
Should exist something else for MacOS I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now if we have TransactionDetails or TransferViewController on top оf the chat, messages in chat will not be available to read and reeding will be triggered after dissmiss