Skip to content

fix: validate access override expiry #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tsammie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate access override expiry #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/access-api/src/services/memberService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,19 @@ export class MemberServiceError extends Error {
}
}

function parseExpiresAt(value: string | null | undefined): Date | null {
if (!value) return null;

const expiresAt = new Date(value);
if (Number.isNaN(expiresAt.getTime())) {
throw new MemberServiceError("Invalid expiresAt", 400);
}
if (expiresAt.getTime() <= Date.now()) {
throw new MemberServiceError("expiresAt must be in the future", 400);
}

return expiresAt;
}
// normaliseWallet is imported from ../lib/wallet — single shared source (#173).

function getNormalizedMembershipState(
Expand Down Expand Up @@ -1018,6 +1031,7 @@ export function getMemberService(
) {
throw { statusCode: 400, message: "Invalid override payload" };
}
const parsedExpiresAt = parseExpiresAt(expiresAt);

const requester = await prismaClient.wallet.findUnique({
where: { address: normalizedRequesterWallet },
Expand All @@ -1030,7 +1044,6 @@ export function getMemberService(
});
assertMemberPermission(requesterMember?.roles, "write:overrides", false);

const parsedExpiresAt = expiresAt ? new Date(expiresAt) : null;
const { wasExisting } = await prismaClient.$transaction(async (tx: any) => {
await validateAndEvaluateMutation(tx, {
action: "OVERRIDE_CREATE",
Expand Down
Loading