test: add CSRF origin and Referer coverage#318
Merged
Lakes41 merged 1 commit intoJul 24, 2026
Conversation
Contributor
Author
|
Withdrawing this contribution. Thanks for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296.
Adds direct coverage for CSRF expected-origin resolution and mutation header validation. The headerless POST case is pinned to the current fail-closed 403 behavior from #316.
Tests:
node --test test-dist/test/csrf.test.js: 12 passed, 0 failed.node --experimental-test-coverage --test test-dist/test/csrf.test.js:lib/csrf.tsreached 100% line, branch, and function coverage.npm test: this branch and upstream main both stop before execution on the same 3 existing TypeScript diagnostics incomponents/nav.tsx.member-cache.test.jsconfiguration failure.npm run typecheck: branch and main both report the same 17 existing errors.npm run lint: branch and main both report the same 8 existingreact/no-unescaped-entitieserrors.npm run check-types: passes on branch and main.npm ci: cannot start because the upstream lockfile omitses-abstract@1.24.2; dependencies were installed withnpm install --package-lock=falseinstead.