feat: add runtime validation for listAdminEvents endpoint (#267)#344
Merged
Lakes41 merged 1 commit intoJul 26, 2026
Merged
Conversation
Adds WebhookEventSchema and PaginatedSchema to the auto-generated types file, and uses them to validate the listAdminEvents response at runtime. This ensures every documented live endpoint response is now runtime-validated against a zod schema derived from openapi.json, completing the coverage for issue Adamantine-guild#267. - Adds WebhookEventSchema (zod) alongside the WebhookEvent interface - Adds PaginatedSchema helper for generic paginated response validation - Updates listAdminEvents to pass schema to getJson for runtime validation The existing sync-types/check-types compile-time guarantee is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267
Adds WebhookEventSchema and PaginatedSchema zod schemas alongside the existing interfaces in the auto-generated types file, and wires them into listAdminEvents so every documented live endpoint now has runtime response validation.
Changes:
The existing sync-types/check-types compile-time pipeline is preserved.
Acceptance criteria: