Skip to content

Conversation

@keharper
Copy link
Contributor

@keharper keharper commented Aug 7, 2025

Purpose of this pull request

This pull request (PR) adds Redocly variables to the repo and adds a basic yaml file for testing.

Affected pages

  • ...

Links to Magento Open Source code

  • ...

@keharper keharper self-assigned this Aug 7, 2025
@keharper keharper added enhancement New feature or request internal Differentiates work between external and internal contributors labels Aug 7, 2025
@github-project-automation github-project-automation bot moved this to 📋 Needs Review in Commerce - Pull Requests Aug 7, 2025
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keharper,

FWIW, i recommend moving the OpenAPI spec to a new directory at commerce-extensibility/static/rest/extensibility.yaml or some variation of that. The important thing is to put it in a static/ directory.

That way, you can reference the path to the spec in the redocly block as such:

<RedoclyAPIBlock src='/commerce/extensibility/rest/extensibility.yaml' />

See AdobeDocs/commerce-services#284 for an example.

I think that this will make it easier to validate changes that you make to the spec now and in the future when you deploy to stage. If you use the raw github URL, I think you'll have to update the spec AND update the raw URL in the redocly block, which doesn't seem ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request internal Differentiates work between external and internal contributors

Projects

Status: 📋 Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants