Tutorial on how to add a custom product attribute input type #150
Conversation
goivvy
changed the title
jeff-matthews
added
the
new-topic
|
Thanks for the contribution @goivvy! While we review, will you please sign the Adobe CLA? It's a requirement for us to merge external contributions. @rparsi-boxycharm, since you were the original reporter for magento/devdocs#9452, would you please take a look and share your feedback? |
|
@jeff-matthews Where is a link to sign the CLA? |
|
@goivvy, if you don't see the link next to the check, then there must be a bug and I'll need to contact the Adobe Open Source Office for assistance. Do you see a link? I assume I don't see it because it's contributor-specific.
|
|
@jeff-matthews I see it but it's not active. I click on it and nothing happens. I signed CLA for https://github.com/magento/devdocs a few years ago, is that different? |
|
Yes, each repo requires a separate signed CLA as far as I know. Can you see a "Details" link next to the check? I can't, but I don't know if I'm supposed to if I'm not the contributor. |
|
@jeff-matthews That's how I see it: |
|
Thanks @goivvy. It looks like there was a GitHub service issue earlier today. We may just need to wait while all services come back and the job queue clears. |
|
@jeff-matthews Still no link to accept the CLA. |
|
@goivvy, can you please try opening a new, test PR in this repo? Maybe the test PR will have the CLA link and we can assume this is a transient issue with the https://github.com/adobe/cla-bot/. |
|
@jeff-matthews I created a test PR but I still don't see a link to sign the CLA - #153 |
|
Thanks @goivvy. I'll work with the maintainers to see how to fix it. |
|
@goivvy, now that GitHub services are all back online and queues have been processed, it looks like the link for the CLA check is now showing as expected. 🙌 And it looks like you've already signed it 😄 |
|
@jeff-matthews I didn't do anything, my signature must've been migrated from the old repo |
|
@jeff-matthews Let me know if you need me to explain code block in the tutorial. |
|
Sorry about the delay @goivvy. I haven't forgotten about this, but I won't be able to get someone to look at it until after our 2.4.7-beta release on 6/13. |
|
@jeff-matthews Alright, it sounds good |
|
I think I found someone to review. Contacted internal engineering manager for assistance. |
|
@jeff-matthews OK, any questions - let me know. |
|
@jeff-matthews I was wondering if they had a chance to review the article. |
|
Hi @goivvy, I checked with the team member (Abhinav Pathak) who is assigned to review last week and they said that they have not started yet. Hopefully, they'll look at it this week. |
|
@jeff-matthews let me know if they had a chance to review the code. |
|
Hi @goivvy, Confirmed that they're reviewing now. |
|
@jeff-matthews any updates? |
|
@dshevtsov, no. |
4 participants
Purpose of this pull request
This pull request (PR) adds a tutorial on how to create a custom product attribute input type. It fixes magento/devdocs#9452 .
Affected pages
Links to Magento Open Source code