fix: reject unauthenticated validator membership changes - #45
Draft
Alicepoltora wants to merge 1 commit into
Draft
fix: reject unauthenticated validator membership changes#45Alicepoltora wants to merge 1 commit into
Alicepoltora wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConsensusEnginequorumSecurity rationale
Validator registration changes quorum and leader election, but the public endpoint has no authenticated authorization path. The current registration-signature check is only a non-empty placeholder, not cryptographic verification. Previously any HTTP caller could cause the receiving node to add a validator to its local consensus set immediately after DAG submission, creating a divergent quorum and a Sybil vector.
Dynamic membership should return only with an authenticated governance/validator-authorization protocol and finalized epoch-bound activation.