Refactoring #72
Open
Refactoring #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
============================================
- Coverage 100.00% 19.51% -80.49%
============================================
Files 16 17 +1
Lines 603 615 +12
============================================
- Hits 603 120 -483
- Misses 0 495 +495
|
|
Removing imports |
|
did a refactoring @someshsingh22. Do take a look at the code and solve for any merge issues |
|
@mehulrastogi |
| import numpy as np | ||
| import torch | ||
|
|
||
| from code_soup.common.perturbation import Perturbation |
There was a problem hiding this comment.
This file according to the factoring will come under vision-> utils. Please do the needful
Also the common perturbation file should come under common->utils
| @@ -1,6 +0,0 @@ | |||
| from code_soup.common.vision.datasets.image_classification import ( | |||
There was a problem hiding this comment.
Will you be importing this directly in the files where required?
| @@ -0,0 +1,12 @@ | |||
| from abc import ABC, abstractmethod | |||
There was a problem hiding this comment.
This abstract method to be under common-utils now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70