Add further robustness if TIDAL or Discord processes close, and recovery from that#4
Open
SkebbZ wants to merge 27 commits into
Open
Add further robustness if TIDAL or Discord processes close, and recovery from that#4SkebbZ wants to merge 27 commits into
SkebbZ wants to merge 27 commits into
Conversation
Added more robustness, script can now handle user closing either TIDAL or Discord and will then sleep until both are back.
Optional AHK script that can be compiled into an EXE and added to OS startup, hiding in the system tray.
Attempt to add more robustness and isolate an issue
fixed the bug when reconnecting and TIDAL is not playing
commented out debug stuff
cleanup redundant stuff and move the manual RPC.close() calls to the quit() function
Optional GUI variant
file extension
avoid infinite scroll, add clear GUI at the end of the main loop at least
add system tray icon with TIDAL logo overlapped by small Discord logo
added GUI info
clarified that AHK method can be used for both CLI and GUI
small info about CLI AHK variant autohiding on launch
minor cleaning and comment out some debug prints. flipped initial value of tidal_paused variable to fix some misleading print outputs
minor cosmetic changes to right click menu in system tray
minor tweaks and removed unneccessary prints like in the CLI version
efficiency updates, now uses less CPU and should almost never hit an exception outside of RPC.connect()
efficiency and logic changes, same as the CLI version to reduce CPU use and rely less on exceptions
added sleep(1) to quit function so it can be read by user before terminating if running from .bat without pause command
fixed missing indentation
comment debug prints
comment debug prints
Can be in the "icon" path in the AHK script to give the script or compiled app an icon in the system tray
Refactor Tidal RPC script to improve code clarity and performance. Updated comments for better understanding and changed tidal_pids from list to set for faster membership testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got this working on startup minimized to system tray with AHK, and now it works rather well with me opening and closing stuff during the day :) I'm sure it could also be done with pythonw.exe and a bat file.