Skip to content

Conversation

@Nadrieril
Copy link
Member

@Nadrieril Nadrieril commented Oct 1, 2024

Fixes #388.

@Nadrieril Nadrieril marked this pull request as draft October 1, 2024 09:23
@msprotz
Copy link
Contributor

msprotz commented Oct 1, 2024

FYI, just gave this a quick try, and I don't seem to be receiving the comments at all anymore (or at least, the one I noticed had a problem)

@Nadrieril
Copy link
Member Author

Nadrieril commented Oct 1, 2024

Yeah I marked it as draft because it doesn't work for complex cases such as destructuring or assert! that you test in Eurydice

@sonmarcho
Copy link
Member

This seems to be rotting. @Nadrieril do you have any plan for this PR?

@Nadrieril
Copy link
Member Author

I was hoping to get back to it when higher-priority items are done, but tbf I don't know how to go about this. The few heuristics I tried don't work and the last idea I had required an important change to the visitors library we're using (so we can hold on to borrows while visiting)

@msprotz
Copy link
Contributor

msprotz commented Nov 5, 2024

Is no one else in the Rust ecosystem doing this? (Retaining inline comments.)

Should this be a discussion with upstream Rustc to add more support in the compiler itself?

@Nadrieril
Copy link
Member Author

I don't know of anyone else doing that no

@Nadrieril Nadrieril self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suboptimal placement of comment

3 participants