Append zero to .ctor section#53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final four bytes of .ctor is always zero and is generated by the linker, so there is no reason for those four bytes to be included in delinks.txt.
Since the .ctor section is now shorter, some false positive symbols and relocations pointing to that zero value will no longer be detected by
dsd init. However, there is one relocation to the ARM9 program's .ctor section that needs to be preserved, so a new link-time constant was added and the data/relocation analyzer accepts arelocation_overrideswhere this special relocation can be registered.Before merging, I will implement a fix command to automatically truncate .ctor sections for already established dsd projects.