Merge master into develop #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AlwaysCm #1019 Havester front hitch unit label always cm
…ncorrect-image-in-config Correct config image for hitch of articulated
Fixes done in other Fixes branch
…too-many Bugfix/1026 one guideline too many and 1025 half of extra guide lines do not show green foreground color.
Rephrase 'Delete For Sure' -> 'Are you sure you want to delete?'
Improves track copying and conversion process. Ensures copied tracks are correctly converted between coordinate systems by saving current track changes, reloading them to include recent edits, and clearing track references before loading new ones. Normalizes track headings and resets worked tracks for new fields, also makes copied tracks visible by default. Recalculates headings for curve points using GeoDir to ensure accuracy during conversion. Refactor track copying: separate business logic from UI - Create stateless TrackCopier class with conversion logic - Move all coordinate conversion code to TrackCopier - Replace custom FieldInfo with FieldDescription from Core - FormCopyTracks now only handles UI interactions - Improves testability and maintainability 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Rename "Copy Tracks" to "Import Tracks" (more accurate terminology) - Remove unused field variables (availableTracks, availableFields as class members) - Use DirectoryInfo directly instead of FieldDescription wrapper - Simplify field comparison using field name only (not full path) - Use early return pattern for validation checks - Make ConvertTracks() private (only CopyTracksToField() is public API) - Keep form open after import to allow multiple imports - Count fields/tracks using Items.Count/Controls.Count directly
After importing tracks, the track index (trk.idx) was set to -1. When the user clicked the cycle backwards button, the index would decrement to -2, causing an ArgumentOutOfRangeException when trying to access trk.gArr[-2]. The fix sets the index to the first visible track after import, ensuring it's always in a valid range when tracks are present.
Adds track copying functionality
Final Merge before Release
richardklasens
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.