Expose attach subpaths and sandbox readonly requests (spawn contract pending) - #1787
Draft
agent-relay-code[bot] wants to merge 3 commits into
Draft
agent-relay-code[bot] wants to merge 3 commits into
agent-relay-code[bot] wants to merge 3 commits into
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft implementation of the attach and read-only-request portions of the workforce#338 upstream work. This does not yet unblock workforce#338. The reviewed plan's D4 decision is pending:
spawnFleetSandboxmust either orchestrate a running agent or expose a narrower ensure-only contract. No placeholderspawnFleetSandboxis exported./attachentries, nodeId/optional-agent discovery, a private single-client raw stdio socket, idempotent cleanup, and a completion promise./fleet; route the CLI's ensure import through the SDK entry. Preserve existing Cloud enrollment APIs. The running-agent spawn wrapper remains pending D4.readonlyPathsas explicit/path/**subtrees; exposefleet spawn --sandbox-readonly-pathwith mount guards.The proxy retains broker transport fields alongside socketPath/finished/close, as the reviewed plan recommends: workforce duck-types the three consumer fields and ignores extras. Completion is an inferred status (0 for normal terminal closure/detach, 1 for transport failure), not a remote harness exit code. SDK re-exports add a dependency on Cloud and its transitive dependencies. No package versions changed.
Remaining requirements
spawnFleetSandboxregistration, placement confirmation, input mapping, and teardown.requirecondition was added.Validation
npm run typecheck: passed.npm run build: passed (Rust build skipped automatically because Cargo is unavailable).npx vitest run packages/cli/ --maxWorkers=2: 1,652 passed, 29 skipped.npm --prefix packages/cli testis unavailable because that package has no test script. Tests ran without inherited Cloud/Relay credentials and with local Git file transport enabled for the temporary-repository fixture.c978302and implementationb6c3bb1: baseabsent, headfixed. Both generated probes and compiled CLI-help checks passed. This was not a hosted Cloud or live Daytona run.RelayFlow Proof
featuresandbox-readonly-pathsThis generated base/head probe verifies exact request forwarding and compiled CLI help. It does not provision a sandbox or prove chmod enforcement.