Skip to content

fix(shortcuts): align session nav with sidebar (follow-up to #2954) - #2964

Open
AllBeingsFuture wants to merge 1 commit into
AgentWrapper:mainfrom
AllBeingsFuture:fix/2954-session-nav-active
Open

fix(shortcuts): align session nav with sidebar (follow-up to #2954)#2964
AllBeingsFuture wants to merge 1 commit into
AgentWrapper:mainfrom
AllBeingsFuture:fix/2954-session-nav-active

Conversation

@AllBeingsFuture

Copy link
Copy Markdown

Summary

Follow-up / re-host of #2954 with the review bug fixed.

Original PR head is aprv10:feat/command-palette-shortcut-reference (cross-repo). This account cannot push there (403), so the fix is published from AllBeingsFuture:fix/2954-session-nav-active.

Fix

  • Session prev/next navigation now uses workerSessions(...).filter(sessionIsActive) — same live set as the sidebar (excludes merged / terminated-merged, not only status !== "terminated").
  • Focus-terminal shortcut scoped to the active session pane (not the first .xterm-helper-textarea in the document).
  • Tests + typecheck green locally (cddd69a9).

Includes original #2954 feature commits + this fix.

Test plan

  • Cmd/Ctrl+[/] cycles only active worker sessions (skips merged/terminated)
  • Focus-terminal focuses the active session terminal
  • Frontend unit tests for shell shortcuts

@somewherelostt

Copy link
Copy Markdown
Collaborator

Thanks for contributing to Agent Orchestrator.

This PR is being picked up by the current external contributor on-call pair:

If someone is already working on this, please continue as usual.
The on-call pair is added for visibility, tracking, and support, not to take over the work.
If you need help with review, direction, reproduction, or next steps, please tag @illegalcall and @Pulkit7070 here.

For faster context or live questions, you can also join the AO Discord.

Join the session here:
https://discord.gg/H6ZDcUXmq

Come by if you want to see what is being built, ask questions, or just hang around with the community.

Use workerSessions + sessionIsActive for prev/next so merged,
terminated-merged, and orchestrator sessions are not cycled. Scope
terminal focus to the active session pane.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants