feat(frontend): flush Windows center panel and lighter terminal background#3083
Merged
Vaibhaav-Tiwari merged 1 commit intoJul 25, 2026
Conversation
…round - Add a platform-windows class on the shell root and drop the framed center panel's top inset on Windows, where the custom titlebar already supplies top chrome; other platforms unchanged. - Lighten the dark-theme terminal background token (#15171b -> #101317e7).
JAYATIAHUJA
requested review from
Hardik180704,
Pulkit7070,
Vaibhaav-Tiwari,
codebanditssss and
somewherelostt
July 24, 2026 21:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small desktop UI polish items from a Windows visual pass:
platform-windowsclass, and.platform-windows .center-panel-shelloverridespadding-topto0— the framed panel sits flush under the custom titlebar instead of leaving a 12px dark gap.--color-bg-terminalgoes from#15171bto#101317e7(slight translucency). Light theme untouched.Why
On Windows the frameless window's custom titlebar already supplies the top chrome, so the shared 12px top inset read as dead empty space above the framed panel. The terminal background was visually indistinguishable from surrounding surfaces; the new shade gives it a distinct, slightly lighter tone.
How
isWindowsin_shell.tsx; the override is a single CSS rule instyles.css, so macOS/Linux and all component internals are untouched.tokens.css— no hardcoded colors in components; xterm picks it up viabuildTerminalThemes()on reload.Testing
npm run typecheck(frontend) passes;prettier --checkpasses on all touched files.npm run dev) on Windows: panel renders flush under the titlebar; terminal shows the new shade after reload.platform-windowsclass present and computed panel padding overridden.Checklist
main(or continuing an existing PR branch)go, frontend, etc.)