fix(linux): match mac shell chrome (framed board + titlebar cluster)#3129
Merged
Conversation
linux rendered a separate `□ ← → Board` shell topbar while mac framed the board and put the sidebar toggle + history arrows in a fixed titlebar cluster. unify linux onto the mac path: - hidesShellTopbar() now covers linux, so the board/session actions and the Board crumb mount in-panel (framed) instead of in a shell topbar - TitlebarNav renders on linux too, pinned at the sidebar's top-left (no traffic lights to offset past) - the sidebar reserves the same titlebar band (underTopbar) on linux - drop the inline linux-only sidebar toggle — the fixed cluster replaces it, which also fixes the collapse-vanish bug (the fixed cluster survives an off-canvas collapse, so there's always a way to expand) windows is unchanged. supersedes #3124.
the sidebar reserved a titlebar band on linux but the center panel still used the default (non-mac) insets, so the board/session title sat at the wrong height and the fixed cluster crowded the panel's top-left corner. apply the mac center-panel alignment on linux too (near-flush inset + 36px title bar level with the cluster). linux has no traffic lights, so the sidebar-closed title clears the cluster from its own left edge via a linux content-offset token instead of the macOS 79px offset.
the linux cluster sat at top-1.5 (6px), centering its 36px box at y24 while the framed board titlebar centers at y21 (mac inset 2px + surface border 1px) — so the toggle/arrows read as misaligned against the project title. drop to top-0.75 (3px) so both share the same centerline. measured with a throwaway playwright pass under a linux UA: cluster and title now both center at y21.
Collaborator
|
please add screenshots |
Collaborator
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux had its own
□ ← → Boardshell topbar while mac frames the board and keeps the sidebar toggle + history arrows in a fixed titlebar cluster. this makes linux use the mac path so the two look the same.what changed
hidesShellTopbar()now covers linux → board/session actions and the Board crumb mount in-panel (framed), not in a separate shell topbarTitlebarNavrenders on linux too, pinned at the sidebar's top-left (no traffic lights to offset past)underTopbar)windows is untouched.
supersedes #3124
that PR fixed the collapse-vanish by switching linux to an icon rail. this takes the fuller "match mac" route the vanish fix falls out of, so #3124 can close if this lands.
verification
tsc --noEmitclean, full renderer suite green (754 tests); updatedplatform.test.tsfor the new linux expectationstop-1.5 left-1.5) and the reserved band are matched to the mac path but eyeballed. easy to nudge if the spacing is off.