Add update_freq_mask method
#105
Open
+54
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-sasatani
force-pushed
the
feat_update_freqmask
branch
from
9936171 to
93567d5
Compare
|
As I see it it basically just preparing the code for an adaptive filtering right? There is no mechanism for the mask to change based on feedback from the processed frames (like a noise estimation). It would still take the user pre-defined values for all frames. |
MarcelMB
approved these changes
Feb 20, 2025
Comment on lines
+386
to
+388
| """ | ||
|
|
||
| self._freq_mask = self._gen_freq_mask( |
There was a problem hiding this comment.
does it make sense to add logging here:
logging.info(f"Updating frequency mask with vertical_BEF_cutoff={vertical_BEF_cutoff}, "
f"horizontal_BEF_cutoff={horizontal_BEF_cutoff}, "
f"spatial_LPF_cutoff_radius={spatial_LPF_cutoff_radius}")
to see successfully updated values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method for updating the frequency mask during processing. If we want to do adaptive frequency masking in the
mio process denoisemodule, addingfreq_mask_processor.update_freq_mask(params)right before the following code (which processes each frame in theforloop) should be most straightforward.mio/mio/process/video.py
Line 553 in 9936171
📚 Documentation preview 📚: https://miniscope-io--105.org.readthedocs.build/en/105/