Make config_sources
a classmethod rather than a class property
#109
+39
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python 3.13 removed the ability to use
@classmethod
s and@property
together - https://docs.python.org/3.13/library/functions.html#classmethodThis causes a bug when using
id
s to load configs like:so this is just a PR to switch it to being a classmethod.
first committing updated ci action that tests against 3.13 to confirm failure, then committing fix.
While refactoring the method, i noticed that usages were not being detected correctly by pycharm. this was because of the generic TypeVar i was using incorrectly rather than the
Self
annotation, which is the correct annotation for classmethods that behave like constructors of subclasses, so i also fixed that.📚 Documentation preview 📚: https://miniscope-io--109.org.readthedocs.build/en/109/