Skip to content

Fix count SQL semicolon trimming - #1

Closed
Aias00 wants to merge 1 commit into
mainfrom
fix/sqlutils-count-trim
Closed

Fix count SQL semicolon trimming#1
Aias00 wants to merge 1 commit into
mainfrom
fix/sqlutils-count-trim

Conversation

@Aias00

@Aias00 Aias00 commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • trim generated count SQL using its own length instead of the original SQL length
  • reuse the same trailing-semicolon helper for fallback count SQL wrapping
  • add focused SqlUtils tests for count SQL semicolon handling

Verification

  • mvn -B -f chat2db-community-server/pom.xml -pl :chat2db-community-spi -am -Dmaven.test.skip=false -DskipTests=false -Dtest=SqlUtilsTest -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.test.failure.ignore=false test
  • mvn -B -f chat2db-community-server/pom.xml -pl :chat2db-community-spi -am -Dmaven.test.skip=true package

Copilot AI review requested due to automatic review settings July 23, 2026 10:48
Copilot AI reviewed Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 23, 2026

Copy link
Copy Markdown
Owner Author

Closing this fork-local PR because the intended upstream PR is OtterMind#1966.

@Aias00 Aias00 closed this Jul 23, 2026
openai0229 pushed a commit that referenced this pull request Sep 16, 2026
@liushikuan63
Merge pull request #1 from liushikuan63/codex/import-export-01-jdbc-t…
7dbc783 
…ransactions

fix(spi): preserve JDBC transaction ownership in batch imports
openai0229 pushed a commit that referenced this pull request Sep 16, 2026
@liushikuan63
Merge upstream main into main (sync the fork before the fast-mode PR)
a8e78dd 
Keeps the fork's own history (the PR #1 JDBC transaction-ownership fix)
and brings main up to upstream so the batch-1 PR shows only the feature
diff instead of the whole upstream delta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aias00