Skip to content

Conversation

@dubzn
Copy link
Contributor

@dubzn dubzn commented May 10, 2025

Pull Request Overview

📝 Summary

Enhance BeastStats model with state management and attribute handling logic

Related Issues

Type of Change

Mark with an x all the checkboxes that apply (like [x]).

  • 📝 Documentation (updates to README, docs, or comments)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 👌 Enhancement (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

🔄 Changes Made

What's Changed

Implementation Details

The changes are detailed in the issue #83, I used it as a guide.

Technical Notes

N/A

🔧 Tests Results

Unit testing

Test Coverage

  • Unit Tests
  • Integration Tests
  • Manual Testing

Evidence

image

Testing Notes

N/A

🔜 Next Steps

N/A

@dubzn
Copy link
Contributor Author

dubzn commented May 10, 2025

Hey @coxmars, I noticed that StatusCondition::Weakness and StatusCondition::Stunned don't exist.
Should I add them?

@coxmars
Copy link
Contributor

coxmars commented May 14, 2025

Hey @coxmars, I noticed that StatusCondition::Weakness and StatusCondition::Stunned don't exist. Should I add them?

Yes please

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dubzn it looks really good, just try to add the status and we are good to merge, thanks for your valuable help 🚀

@dubzn
Copy link
Contributor Author

dubzn commented May 14, 2025

@dubzn it looks really good, just try to add the status and we are good to merge, thanks for your valuable help 🚀

Done! Ty for review

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coxmars coxmars merged commit 1e9c310 into AkatsukiLabs:main May 28, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📝 [FEAT]: Improve BeastStats model with status management

2 participants