-
Notifications
You must be signed in to change notification settings - Fork 50
ci: remove --check flag from scarb fmt command #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The --check flag was removed to make the CI workflow actually format the code rather than just checking the formatting. This ensures consistent code style across the codebase. ``` Key points about this commit message: 1. Type is `ci` since it's modifying a GitHub workflow file 2. No scope needed as it's clear from context 3. Description explains what changed (removed --check flag) and why (to actually format code) 4. Body provides additional context about ensuring consistent code style 5. Ignores the bash.exe.stackdump file as it appears to be an accidental crash dump that shouldn't be committed
bash.exe.stackdump
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AfroTechBoss delete this file
|
@AfroTechBoss Why did you upload this file? It looks very strange and a bit malicious |
|
Hi @coxmars I have removed it and pushed again. |
The file appears to be a crash dump that was accidentally committed and is not needed in the repository. Removing it helps keep the repository clean.
Do not worry, thanks for the explanation sir 🫡 |
The --check flag was removed to make the CI workflow actually format the code rather than just checking the formatting. This ensures consistent code style across the codebase.