Skip to content

Conversation

@KevinMomanyi
Copy link

Pull Request Overview

📝 Summary

#Tasks

  1. Write tests for:
    test_beast_type_to_u8(), test_u8_to_beast_type_valid(), test_u8_to_beast_type_invalid() and test_beast_type_to_felt252() using str_to_felt252()
  2. Verify bidirectional mapping
    test_bidirectional_mapping()
  3. Edge case testing
    test_u8_to_beast_type_invalid()

Related Issues

  • Closes #(issue number) Replace with actual issue number.

Type of Change

Mark with an x all the checkboxes that apply (like [x]).

  • 📝 Documentation (updates to README, docs, or comments)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 👌 Enhancement (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

🔄 Changes Made

What's Changed

Provide a clear and concise description of what you changed and why.

Implementation Details

Describe how you implemented the changes.

Technical Notes

Include any technical details that reviewers should be aware of.

🔧 Tests Results

Describe the tests you performed to verify your changes.

Test Coverage

  • [X ] Unit Tests
  • Integration Tests
  • Manual Testing

Evidence

Provide relevant evidence of testing (screenshots, test outputs, etc.).

Testing Notes

Include any special testing considerations or edge cases checked.

🔜 Next Steps

Indicate actions or improvements to be taken after this PR, if applicable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinMomanyi add unit tests in the same file of the beast_type.cairo please

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KevinMomanyi please remove the scarb files from this PR, we only need the unit tests in the beast.cairo

@KevinMomanyi
Copy link
Author

well noted @coxmars , thanks.

coxmars
coxmars previously approved these changes Jun 15, 2025
Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinMomanyi solve the issues in the workflow, the unit tests are not passing

@coxmars coxmars dismissed their stale review June 15, 2025 05:03

Mistake in the review

@coxmars coxmars closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants