Skip to content

full stack developer challange#30

Open
MzkZeeshan wants to merge 2 commits into
Akkadu:masterfrom
MzkZeeshan:full-stack-engineer/zeeshan_khan
Open

full stack developer challange#30
MzkZeeshan wants to merge 2 commits into
Akkadu:masterfrom
MzkZeeshan:full-stack-engineer/zeeshan_khan

Conversation

@MzkZeeshan

Copy link
Copy Markdown

Description

Please describe the purpose of the pull request.

Checklist

  • [yes ] All tests are passing
  • [ yes] New tests were created to address changes in pr (and tests are passing)
  • [ yes] Updated README and/or documentation, if necessary
  • [ yes] Added myself / the contributors array in package.json

CHAT
https://mzkchatroom.surge.sh/
PRODUCT REVIEW
https://product-review.surge.sh/
IMAGE PROCESSING
https://fluffy-frog.surge.sh/
Thanks for contributing!

@MzkZeeshan MzkZeeshan marked this pull request as draft April 20, 2022 19:01
@MzkZeeshan MzkZeeshan marked this pull request as ready for review April 20, 2022 19:01

@deevannaveed deevannaveed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MzkZeeshan, thanks for attempting all the 3 challenges, was great that I could test your tasks very easily using serge.sh, I have some comments below, feel free if you want to improve based on my feedback, some of the the other candidates are also improving the things we request so you have time till Sunday.

  1. I can see you have used Firebase and I think it would be better if you have created your own API for all the projects or at least one.
  2. We expect all the projects to be mobile responsive.
  3. In product review API it would be good if a user can login and add his/her review and then that should be the only user to delete and update his/her review, in your case any user is able to add and delete the review of any user.
  4. In the product review API we were expecting the user to provide ratings as well, as in most apps a review must have rating.
  5. The image processing app should process the images on the server not on the front-end and users should be able to download the images after processing.

@MzkZeeshan

MzkZeeshan commented May 8, 2022

Copy link
Copy Markdown
Author

Hi @MzkZeeshan, thanks for attempting all the 3 challenges, was great that I could test your tasks very easily using serge.sh, I have some comments below, feel free if you want to improve based on my feedback, some of the the other candidates are also improving the things we request so you have time till Sunday.

  1. I can see you have used Firebase and I think it would be better if you have created your own API for all the projects or at least one.
  2. We expect all the projects to be mobile responsive.
  3. In product review API it would be good if a user can login and add his/her review and then that should be the only user to delete and update his/her review, in your case any user is able to add and delete the review of any user.
  4. In the product review API we were expecting the user to provide ratings as well, as in most apps a review must have rating.
  5. The image processing app should process the images on the server not on the front-end and users should be able to download the images after processing.

sorry sir I don't have much time for that and I think it should be enough for hire process
thanks
Muhammad Zeeshan Khan

@MzkZeeshan MzkZeeshan requested a review from deevannaveed May 31, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants