Open
Conversation
ABBA-74
reviewed
Jan 20, 2023
| { | ||
| "liveServer.settings.port": 5501 | ||
| "liveServer.settings.port": 5502 | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
ok it's done
AlaAtrash
requested changes
Jan 20, 2023
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "liveServer.settings.port": 5501 | |||
| ### Langage et Package | ||
|
|
||
| - TypeScript | ||
| - Nodejs |
Collaborator
Author
There was a problem hiding this comment.
the rebase didn't work for this file, so I copied the main
| $ "files": ["src/index.ts", "src/sin_cos.ts"] | ||
| ``` | ||
|
|
||
| ## Tester son fichier JS |
Collaborator
Author
There was a problem hiding this comment.
the rebase didn't work for this file, so I copied the main
| let affichageResultat = document.querySelector('#resultat'); | ||
| let resultat; | ||
|
|
||
| function multiplication(a, b) { |
Owner
There was a problem hiding this comment.
you can use arrow function instead
const multiplication = (a,b) => {
}
Collaborator
Author
There was a problem hiding this comment.
ok I changed
| @@ -0,0 +1,23 @@ | |||
| "use strict"; | |||
| <button class="button-multiplication">Multiplier</button> | ||
| <p id="resultat"></p> | ||
|
|
||
| <script type="module" src="dist/index.js"></script> |
Owner
There was a problem hiding this comment.
<script type="module" src="index.js"></script>
| @@ -0,0 +1,30 @@ | |||
| let inputA = document.querySelector('#numberA') as HTMLInputElement; | |||
Owner
There was a problem hiding this comment.
test document.getElementbyId()
| let resultat: number | ||
|
|
||
|
|
||
| function multiplication(a: number, b: number) { |
Owner
There was a problem hiding this comment.
prefer arrow function
const multiplication= (a: number, b: number) => {
}
|
|
||
| function multiplication(a: number, b: number) { | ||
|
|
||
| if (a == null || b == null || isNaN(a) || isNaN(b)) { |
| "strict": true | ||
| }, | ||
| "files": ["src/index.ts"] | ||
| "files": ["src/index.ts", "src/multiplication.ts"] |
Collaborator
Author
There was a problem hiding this comment.
ok I changed
Owner
|
to do |
…l/css files to dist
…ion - change querySelector to getElementById
…ow function - change querySelector to getElementById" This reverts commit 9145e68.
…l/css files to dist
…o feat/homePageV2
Temp/main
…ion - change querySelector to getElementById
…ow function - change querySelector to getElementById" This reverts commit 9145e68.
…ion - change querySelector to getElementById
…ow function - change querySelector to getElementById" This reverts commit 9145e68.
… into feat/multiplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.