Skip to content

[PWGHF] taskFlow.cxx : solve issue with CorrelationContainer#15279

Merged
apalasciano merged 9 commits intoAliceO2Group:masterfrom
AlexianL:add_FT0_gain_eq
Mar 10, 2026
Merged

[PWGHF] taskFlow.cxx : solve issue with CorrelationContainer#15279
apalasciano merged 9 commits intoAliceO2Group:masterfrom
AlexianL:add_FT0_gain_eq

Conversation

@AlexianL
Copy link
Contributor

@AlexianL AlexianL commented Mar 5, 2026

In this PR I simply correct an issue at the CorrelationContainer level definition.

@vkucera
Copy link
Collaborator

vkucera commented Mar 5, 2026

@AlexianL What kind of issue is this fixing?

@vkucera vkucera marked this pull request as draft March 5, 2026 13:14
@AlexianL
Copy link
Contributor Author

AlexianL commented Mar 5, 2026

@AlexianL What kind of issue is this fixing?

The last commit "correct problem" is supposed to simply change the definition of my correlation containers. I added a change in the userAxis which resulted in my post-processing macro not working anymore. Undoing this change solved the problem.

@AlexianL AlexianL marked this pull request as ready for review March 5, 2026 14:20
@vkucera
Copy link
Collaborator

vkucera commented Mar 5, 2026

@AlexianL What kind of issue is this fixing?

The last commit "correct problem" is supposed to simply change the definition of my correlation containers. I added a change in the userAxis which resulted in my post-processing macro not working anymore. Undoing this change solved the problem.

Please at least mention in the PR title that the problem concerns CorrelationContainer. Otherwise it can be anything and the title is too vague.

@AlexianL AlexianL changed the title [PWGHF] taskFlow.cxx : solve issue [PWGHF] taskFlow.cxx : solve issue with CorrelationContainer Mar 5, 2026
@vkucera
Copy link
Collaborator

vkucera commented Mar 10, 2026

@singhra1994 @apalasciano Please review

@apalasciano apalasciano merged commit 99a9619 into AliceO2Group:master Mar 10, 2026
14 checks passed
auto associatedWeight = 1;
auto loopCounter = 0; // To avoid filling associated tracks QA many times, I fill it only for the first trigger track of the collision
int sampleIndex = gRandom->Uniform(0, configTask.nSamples);
// int sampleIndex = gRandom->Uniform(0, configTask.nSamples);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you commented this line? If you do not use it any more, better to remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still plan to use that line on a later PR, but it was involved in the issue I corrected. So I thought I could let it here until I understand how to implement it without creating an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants