Skip to content

add uid check for cronHPA job exists #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add uid check for cronHPA job exists #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaf50f8
add uid check for cronHPA job exists
Aug 22, 2023
234b56e
Merge branch 'AliyunContainerService:master' into fix/same-name-job
IrisIris Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions pkg/controller/cronmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,26 +224,25 @@ func (cm *CronManager) GC() {
instance := &autoscalingv1beta1.CronHorizontalPodAutoscaler{}

// check exists first
if err := cm.client.Get(context.Background(), types.NamespacedName{
err := cm.client.Get(context.Background(), types.NamespacedName{
Namespace: hpa.Namespace,
Name: hpa.Name,
}, instance); err != nil {
}, instance)
if (err != nil && errors.IsNotFound(err)) || (hpa.ObjectMeta.GetUID() != instance.ObjectMeta.GetUID()) {
exitsts = false
if errors.IsNotFound(err) {
log.Infof("remove job %s(%s) of cronHPA %s in namespace %s", job.Name(), job.SchedulePlan(), hpa.Name, hpa.Namespace)
if found {
err := cm.cronExecutor.RemoveJob(job)
if err != nil {
log.Errorf("Failed to gc job %s(%s) of cronHPA %s in namespace %s", job.Name(), job.SchedulePlan(), hpa.Name, hpa.Namespace)
return true
}
log.Infof("remove job %s(%s) of cronHPA %s in namespace %s", job.Name(), job.SchedulePlan(), hpa.Name, hpa.Namespace)
if found {
err := cm.cronExecutor.RemoveJob(job)
if err != nil {
log.Errorf("Failed to gc job %s(%s) of cronHPA %s in namespace %s", job.Name(), job.SchedulePlan(), hpa.Name, hpa.Namespace)
return true
}
cm.delete(job.ID())
// metrics update
// when a job is in cron engine but not in crd.
// that means the job has been expired and need to be clean up.
KubeExpiredJobsInCronEngineTotal.Add(1)
}
cm.delete(job.ID())
// metrics update
// when a job is in cron engine but not in crd.
// that means the job has been expired and need to be clean up.
KubeExpiredJobsInCronEngineTotal.Add(1)

// metrics update
// ignore other errors
Expand Down