Refactor GitHub unlock resume flow#38
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthrough新增 Changes开发者解锁服务层封装与页面层迁移
Estimated code review effort🎯 4 (Complex) | ⏱️ ~65 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
entry/src/main/ets/pages/SettingsPageV2.ets (1)
609-609: 💤 Low value
restorePendingDeviceCode重复调用Line 609 在
loadSettings()中已调用restorePendingDeviceCode()，但 finally 块中的resumeDeveloperPendingUnlock()会再次调用（line 3804）。建议移除 line 609 的调用，让 resume 方法统一处理恢复逻辑。♻️ 可选优化
this.developerMode = await this.loadBoolean(SettingsKeys.DEVELOPER_MODE, false); this.devKeyActivated = await this.loadBoolean(SettingsKeys.DEV_KEY_ACTIVATED, false); - await DeveloperUnlockService.restorePendingDeviceCode(); // 备份 this.autoBackupEnabled = await SettingsBackupService.isAutoBackupEnabled();Also applies to: 617-619
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@entry/src/main/ets/pages/SettingsPageV2.ets` at line 609, The `restorePendingDeviceCode()` method is being called twice - once at line 609 in the `loadSettings()` method and again through `resumeDeveloperPendingUnlock()` in the finally block at line 3804, causing duplicate invocation. Remove the `DeveloperUnlockService.restorePendingDeviceCode()` call at line 609 and also examine lines 617-619 for any similar duplicate calls to the same method, removing those as well. This will consolidate the restore logic into a single unified invocation through `resumeDeveloperPendingUnlock()` in the finally block.entry/src/main/ets/service/DeveloperUnlockService.ets (1)
134-142: 💤 Low value可考虑并行清理提升性能
6 次顺序写入可以用
Promise.all并行执行，减少 I/O 等待时间。♻️ 可选优化
static async clearPendingDeviceCode(): Promise<void> { DeveloperUnlockService.pendingDeviceCode = null; - await PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_DEVICE_CODE, ''); - await PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_USER_CODE, ''); - await PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_VERIFICATION_URI, ''); - await PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_VERIFICATION_URI_COMPLETE, ''); - await PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_EXPIRES_AT, 0); - await PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_INTERVAL, 0); + await Promise.all([ + PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_DEVICE_CODE, ''), + PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_USER_CODE, ''), + PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_VERIFICATION_URI, ''), + PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_VERIFICATION_URI_COMPLETE, ''), + PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_EXPIRES_AT, 0), + PreferencesUtil.put(SettingsKeys.DEV_GITHUB_PENDING_INTERVAL, 0), + ]); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@entry/src/main/ets/service/DeveloperUnlockService.ets` around lines 134 - 142, The clearPendingDeviceCode method in DeveloperUnlockService currently executes six sequential await calls to PreferencesUtil.put, which blocks on each I/O operation. Instead of awaiting each PreferencesUtil.put call individually, collect all six calls into an array and execute them in parallel using Promise.all. This will significantly reduce total I/O wait time by allowing all preference writes to occur concurrently rather than sequentially.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@entry/src/main/ets/pages/SettingsPageV2.ets`:
- Line 609: The `restorePendingDeviceCode()` method is being called twice - once
at line 609 in the `loadSettings()` method and again through
`resumeDeveloperPendingUnlock()` in the finally block at line 3804, causing
duplicate invocation. Remove the
`DeveloperUnlockService.restorePendingDeviceCode()` call at line 609 and also
examine lines 617-619 for any similar duplicate calls to the same method,
removing those as well. This will consolidate the restore logic into a single
unified invocation through `resumeDeveloperPendingUnlock()` in the finally
block.
In `@entry/src/main/ets/service/DeveloperUnlockService.ets`:
- Around line 134-142: The clearPendingDeviceCode method in
DeveloperUnlockService currently executes six sequential await calls to
PreferencesUtil.put, which blocks on each I/O operation. Instead of awaiting
each PreferencesUtil.put call individually, collect all six calls into an array
and execute them in parallel using Promise.all. This will significantly reduce
total I/O wait time by allowing all preference writes to occur concurrently
rather than sequentially.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1dc3bb64-bd14-4889-a185-ed5b2d9cef75
📒 Files selected for processing (2)
entry/src/main/ets/pages/SettingsPageV2.etsentry/src/main/ets/service/DeveloperUnlockService.ets
qiin2333
force-pushed
the
codex/refactor-github-unlock-flow
branch
from
72ecc07 to
fde7e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by CodeRabbit
发布说明