Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules.conf: update for Asterisk 22.x.x #468

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Allan-N
Copy link
Collaborator

@Allan-N Allan-N commented Jan 26, 2025

A number of Asterisk modules were deprecated (and removed) in 21.x.x and 22.x.x. These changes update the ASL3 provided "modules.conf" file to sync with those changes as well as some overdue cleanup.

*** NOTE ***
The file currently includes some added content and a bunch of questions. For those reviewing the changes, your comments and guidance are welcomed.

A number of Asterisk modules were deprecated (and removed) in 21.x.x and
22.x.x.  These changes update the ASL3 provided "modules.conf" file to
sync with those changes as well as some overdue cleanup.

*** NOTE ***

The file currently includes some added content and a bunch of questions.
For those reviewing the changes, your comments and guidance is welcomed.
@Allan-N Allan-N self-assigned this Jan 26, 2025
@wd5m
Copy link

wd5m commented Jan 26, 2025

I happened to notice this message in the log. Should or can res_adsi.so be changed to noload now?

[2025-01-26 14:47:24.720] WARNING[730005] loader.c: Module 'res_adsi' has been loaded but may be removed in a future release.

David WD5M

@Allan-N
Copy link
Collaborator Author

Allan-N commented Jan 26, 2025

@wd5m : you have raised a good question.

A quick scan of the Asterisk 22.1.1 sources shows that the following modules would emit that message :

  • app_getcpeid.so
  • app_adsiprog.so
  • app_meetme.so
  • res_adsi.so

configs/rpt/modules.conf Outdated Show resolved Hide resolved
configs/rpt/modules.conf Outdated Show resolved Hide resolved
configs/rpt/modules.conf Outdated Show resolved Hide resolved
configs/rpt/modules.conf Outdated Show resolved Hide resolved
configs/rpt/modules.conf Outdated Show resolved Hide resolved
Updated/added module descriptions
@Allan-N Allan-N linked an issue Jan 29, 2025 that may be closed by this pull request
and expanded the module descriptions that were truncated
@Allan-N Allan-N requested a review from mkmer February 13, 2025 01:32
@mkmer
Copy link
Collaborator

mkmer commented Feb 13, 2025

@wd5m : you have raised a good question.

A quick scan of the Asterisk 22.1.1 sources shows that the following modules would emit that message :

* app_getcpeid.so

* app_adsiprog.so

* app_meetme.so

* res_adsi.so

I think app_meetme was removed already, we had to move to app_confbridge.so on our hub when we moved to ASL3.

@InterLinked1
Copy link
Member

I think app_meetme was removed already, we had to move to app_confbridge.so on our hub when we moved to ASL3.

It hasn't actually been removed yet. One of Sangoma's customers or FreePBX (forget which) raised a big stink on it, which temporarily deferred that. Haven't heard any plans of it to be removed in 23 yet, but it'll probably be removed eventually so best to avoid it.

The other 3 modules in the warning (getcpeid, adsiprog, and res_adsi) I saved from removal and and am the maintainer of now. They aren't going to go away, but Josh didn't want to change the status back from "deprecated" to "extended" which is why the warning is there. PhreakScript patches that warning to a notice since it's a bit confusing and can cause alarm for no reason.

configs/rpt/modules.conf Outdated Show resolved Hide resolved
configs/rpt/modules.conf Show resolved Hide resolved
configs/rpt/modules.conf Outdated Show resolved Hide resolved
configs/rpt/modules.conf Outdated Show resolved Hide resolved
configs/rpt/modules.conf Outdated Show resolved Hide resolved
load = format_gsm.so ; Raw GSM data
load = format_h263.so ; Raw H.263 data
load = format_h264.so ; Raw H.264 data
load = format_ilbc.so ; Raw iLBC data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need all these formats? Highly skeptical anyone is using ILBC for example, or G729, etc. And if they are, they shouldn't be

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only format that I added was format_mp3.so

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the other formats could be safely removed then. If we are already disabling most of the modules in this config, many of which are useful to many people, there is little reason in enabling obsolete codecs that nobody uses or should use

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q? when making or receiving a call do we negotiate based on the available / enabled formats? Where do we get that list of formats?

Copy link
Member

@InterLinked1 InterLinked1 Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's as defined in iax.conf + depending on which ones of those are actually loaded/available

These days, I would expect most calls should just be using ulaw or alaw unless there's a good reason not to

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In iax.conf I see mentions of codecs, not formats

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases I think they go hand in hand, but that's right, they're a bit different.
I believe codecs get used for the call, e.g. codec_ulaw, and formats are used for recording/playback, e.g. format_ulaw/format_pcm.

noload = res_http_websocket.so ; HTTP WebSocket Support
noload = res_musiconhold.so ; Music On Hold Resource
load = res_rpt_http_registrations.so ; RPT HTTP Periodic Registrations
load = res_smdi.so ; Simplified Message Desk Interface (SMDI) Resource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not objecting to it, but I'm pretty confident most ASL users aren't using SMDI

configs/rpt/modules.conf Outdated Show resolved Hide resolved
@Allan-N Allan-N requested a review from InterLinked1 February 15, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load bridge_simple by default
6 participants