-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules.conf: update for Asterisk 22.x.x #468
base: master
Are you sure you want to change the base?
Conversation
A number of Asterisk modules were deprecated (and removed) in 21.x.x and 22.x.x. These changes update the ASL3 provided "modules.conf" file to sync with those changes as well as some overdue cleanup. *** NOTE *** The file currently includes some added content and a bunch of questions. For those reviewing the changes, your comments and guidance is welcomed.
I happened to notice this message in the log. Should or can res_adsi.so be changed to noload now?
David WD5M |
@wd5m : you have raised a good question. A quick scan of the Asterisk 22.1.1 sources shows that the following modules would emit that message :
|
Updated/added module descriptions
and expanded the module descriptions that were truncated
I think |
It hasn't actually been removed yet. One of Sangoma's customers or FreePBX (forget which) raised a big stink on it, which temporarily deferred that. Haven't heard any plans of it to be removed in 23 yet, but it'll probably be removed eventually so best to avoid it. The other 3 modules in the warning (getcpeid, adsiprog, and res_adsi) I saved from removal and and am the maintainer of now. They aren't going to go away, but Josh didn't want to change the status back from "deprecated" to "extended" which is why the warning is there. PhreakScript patches that warning to a notice since it's a bit confusing and can cause alarm for no reason. |
configs/rpt/modules.conf
Outdated
load = format_gsm.so ; Raw GSM data | ||
load = format_h263.so ; Raw H.263 data | ||
load = format_h264.so ; Raw H.264 data | ||
load = format_ilbc.so ; Raw iLBC data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need all these formats? Highly skeptical anyone is using ILBC for example, or G729, etc. And if they are, they shouldn't be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only format that I added was format_mp3.so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of the other formats could be safely removed then. If we are already disabling most of the modules in this config, many of which are useful to many people, there is little reason in enabling obsolete codecs that nobody uses or should use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q? when making or receiving a call do we negotiate based on the available / enabled formats? Where do we get that list of formats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's as defined in iax.conf + depending on which ones of those are actually loaded/available
These days, I would expect most calls should just be using ulaw or alaw unless there's a good reason not to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In iax.conf
I see mentions of codecs, not formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases I think they go hand in hand, but that's right, they're a bit different.
I believe codecs get used for the call, e.g. codec_ulaw, and formats are used for recording/playback, e.g. format_ulaw/format_pcm.
configs/rpt/modules.conf
Outdated
noload = res_http_websocket.so ; HTTP WebSocket Support | ||
noload = res_musiconhold.so ; Music On Hold Resource | ||
load = res_rpt_http_registrations.so ; RPT HTTP Periodic Registrations | ||
load = res_smdi.so ; Simplified Message Desk Interface (SMDI) Resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not objecting to it, but I'm pretty confident most ASL users aren't using SMDI
A number of Asterisk modules were deprecated (and removed) in 21.x.x and 22.x.x. These changes update the ASL3 provided "modules.conf" file to sync with those changes as well as some overdue cleanup.
*** NOTE ***
The file currently includes some added content and a bunch of questions. For those reviewing the changes, your comments and guidance are welcomed.