Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deploy examples to GitHub Pages #104

Merged
merged 5 commits into from
Mar 28, 2025
Merged

chore: Deploy examples to GitHub Pages #104

merged 5 commits into from
Mar 28, 2025

Conversation

lanesawyer
Copy link
Collaborator

What

  • Deploys the examples site to GitHub Pages

How

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer lanesawyer requested a review from a team as a code owner March 27, 2025 23:24
@lanesawyer lanesawyer marked this pull request as draft March 28, 2025 00:03
@lanesawyer
Copy link
Collaborator Author

Almost got it all working, but the built dist version does not like the fact that /layers is just an HTML file. The dev server is doing something to just load it but it doesn't happen on the dist...

We need to migrate the layers demo to React.

crispipear
crispipear approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@crispipear crispipear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to get the deploy workflow in since these changes aren't changing the core code :)

@lanesawyer lanesawyer marked this pull request as ready for review March 28, 2025 16:54
@lanesawyer lanesawyer merged commit ebef990 into main Mar 28, 2025
5 checks passed
@lanesawyer lanesawyer deleted the lane/deploy-examples branch March 28, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crispipear crispipear crispipear approved these changes

@Jarbuckle Jarbuckle Awaiting requested review from Jarbuckle Jarbuckle is a code owner automatically assigned from AllenInstitute/app-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanesawyer @crispipear