Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Logger with log levels #97

Merged
merged 2 commits into from
Mar 15, 2025
Merged

chore: Logger with log levels #97

merged 2 commits into from
Mar 15, 2025

Conversation

lanesawyer
Copy link
Collaborator

@lanesawyer lanesawyer commented Mar 14, 2025

What

  • Adds a logger
  • Replaces console. calls with the logger calls
  • Added Biome rule to error on console usages
  • Adds an input box to the OMEZarr examples to hot-swap URLs

How

  • Got a simple logger from Copilot
  • Tweaked the logger
  • Used it
  • Added the rule to biome.json
  • Added an input box and a useState and a few tweaks to get it to reload the URL

Screenshots

image

image

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer lanesawyer requested a review from a team as a code owner March 14, 2025 00:16
Copy link
Contributor

@Jarbuckle Jarbuckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

@lanesawyer lanesawyer merged commit ea464b8 into main Mar 15, 2025
4 of 5 checks passed
@lanesawyer lanesawyer deleted the lane/logger branch March 15, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants