Skip to content
This repository was archived by the owner on Apr 14, 2020. It is now read-only.

Conversation

C-Lodder
Copy link

@C-Lodder C-Lodder commented Feb 1, 2020

This is currently a draft PR.
I will continue working on this if one of the maintainers agrees with the changes.

Changes so far:

  • Update dependencies
  • Start rewriting jQuery in vanilla JS
  • Start rewriting in ES6
  • Move JS from HTML to separate JS file
  • Move CSS from HTML to separate files
  • Improve performance
  • Remove unecessary code
  • Start utilising SVG's

@HaydenMeloche
Copy link
Member

Hi @C-Lodder, these changes look great if you're interested in working on these :)

@HaydenMeloche
Copy link
Member

HaydenMeloche commented Feb 2, 2020

Another thing I'd like to at some point is moving the CSS out of the HTML files as well

@C-Lodder
Copy link
Author

C-Lodder commented Feb 2, 2020

@HaydenMeloche good news. I'll continue working on this tomorrow.
And yeah I'll move the styling out into SCSS files and use Gulp to compile it.
Need to do a fair bit of testing as the dependency updates were fairly big jumps

@C-Lodder C-Lodder changed the title Javascript improvements Javascript/HTML/CSS improvements Feb 4, 2020
@C-Lodder
Copy link
Author

C-Lodder commented Feb 4, 2020

@HaydenMeloche On the "Textures" page, should the download button work in a test environment?

@HaydenMeloche
Copy link
Member

@C-Lodder As of right now we don't really have any 'test' environment really. The download button as of right now would just hit the same server our live application would

@C-Lodder
Copy link
Author

C-Lodder commented Feb 6, 2020

Hmm, in which case that's the main feature that's not working. I'll continue looking into this today

@C-Lodder C-Lodder marked this pull request as ready for review February 6, 2020 11:30
@C-Lodder
Copy link
Author

C-Lodder commented Feb 6, 2020

@HaydenMeloche I've take the PR out of draft and it's ready for review.

There's still a lot of jQuery code in the package, but I'll rewrite the rest of this in perhaps the next version

@C-Lodder
Copy link
Author

@HaydenMeloche is there any update on this?

@HaydenMeloche
Copy link
Member

hi @C-Lodder sorry, I'm out of my normal country at the moment for about another week or so. I can take a better look when I am back!

@HaydenMeloche
Copy link
Member

Thanks for your hardwork!

Copy link
Member

@Carsillas Carsillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the config change from me

@C-Lodder
Copy link
Author

C-Lodder commented Mar 1, 2020

@HaydenMeloche @burnss9 I've reverted the config.json. If there's anything else that stands out, please let me know.

@C-Lodder C-Lodder requested a review from Carsillas March 3, 2020 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants