warnings pass done on macOS w/ clang #1478
Conversation
|
@nicolemarsaglia there is another set of warnings related to missing braces in the seed point def logic here: I think there is also a tabs vs spaces war going on b/c it's hard for me to whip them into shape. We want spaces. |
For sure! On it! |
|
@nicolemarsaglia @emily-howell can you take a quick looks at these warnings fixes? Want another set of eyes to check for subtle mistakes. |
| seeds.push_back(vtkm::Particle({x,y_max,z}, seed_count++)); | ||
| } | ||
| } | ||
| for(int j = 0; j < num_seeds_y; ++j) |
There was a problem hiding this comment.
so weird that this is aligned in my visual studio. I guess there are tabs hidden. I'll do it again. Compare between there and here.
There was a problem hiding this comment.
Should we be using something like clang-format to apply consistent formatting to all our changes?
There was a problem hiding this comment.
Yes, barriers to get there are creating a style file and deciding on how we want clang format to be applied (via a CI job, or always during development)
There was a problem hiding this comment.
I would opt for during development personally? I'm not sure about Visual Studio but in VSCode you can have it format on save which is pretty easy. Maybe have a CI check that verifies it has been used during development?
I would be happy to make a style file once I finish up my current tickets
There was a problem hiding this comment.
I'll have a few style suggestions :-), if you can get this moving that would be awesome.
There was a problem hiding this comment.
This was also requested for conduit -- they can share the same style rules.
|
Looks good to me now too! |
No description provided.