Include Yaml #1482
Open
Include Yaml #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments-ideas-include-yaml
cyrush
reviewed
Mar 19, 2025
|
|
||
| #ifdef ASCENT_MPI_ENABLED | ||
| // make sure all ranks error if the parsing on rank 0 failed. | ||
| MPI_Bcast(&include_file_valid, 1, MPI_INT, 0, mpi_comm); |
There was a problem hiding this comment.
If we have an error, we should broadcast the error message from rank 0 to all other ranks so their exceptions match
src/libs/ascent/ascent.cpp
Outdated
| #ifdef ASCENT_MPI_ENABLED | ||
| relay::mpi::broadcast_using_schema(node, 0, mpi_comm); | ||
| #endif | ||
|
|
||
| detail::load_included_files_in_node_tree(node, mpi_comm_id); | ||
| node.print(); |
…-2-14_1435-a-few-actions-improvements-ideas-include-yaml
Broadcasting error message to all ranks. Removing print statement.
…clude-yaml' of github.com:Alpine-DAV/ascent into task/2025-2-14_1435-a-few-actions-improvements-ideas-include-yaml
|
@cyrush Thank you for the feedback. I addressed your comments |
cyrush
reviewed
Mar 19, 2025
src/libs/ascent/ascent.cpp
Outdated
| MPI_Bcast(&line_size, 1, MPI_INT, 0, mpi_comm); | ||
| if (rank != 0) | ||
| emsg.resize(line_size); | ||
| MPI_Bcast(const_cast<char*>(emsg.data()), line_size, MPI_CHAR, 0, mpi_comm); |
There was a problem hiding this comment.
it's scary to write into an std::string as a buffer, how about:
Node n_emsg;
if(rank == 0)
{
n_emsg.set(emsg);
}
relay::mpi::broadcast_using_schema(n_emsg, 0, mpi_comm);
emsg = n_emsg.as_string();
There was a problem hiding this comment.
That is a much better way of doing that. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.