Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device copy for uints & ints #1495

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

nicolemarsaglia
Copy link
Contributor

add data field conversion for uint32 and commented back in ints 32 &64

@cyrush
Copy link
Member

cyrush commented Mar 28, 2025

@nicolemarsaglia

124: braid_int8
124: WE ARE IN UNSUPPORTED DATA TYPE: int8
124: braid_int16
124: WE ARE IN UNSUPPORTED DATA TYPE: int16
124: braid_int32
124: [Error] Ascent::execute 
124: file: /__w/1/s/src/libs/ascent/runtimes/ascent_main_runtime.cpp
124: line: 2236
124: message: 
124: Execution failed with vtkm: Could not find appropriate cast for array in CastAndCall.
124: Array: valueType=i storageType=N4vtkm4cont15StorageTagBasicE 27 values occupying 108 bytes [0 1 2 ... 24 25 26]
124: TypeList: N4vtkm4ListIJfdEEE
124: 
124: (Stack trace unavailable)

We may need to do a conversation from one int type to another, depending on what vtk-m build supports.

@cyrush
Copy link
Member

cyrush commented Mar 28, 2025

@nicolemarsaglia mabye this case will work with vtk-m 2.2 + ?

Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you tackled the cases, thanks!

@cyrush cyrush mentioned this pull request Mar 31, 2025
@nicolemarsaglia nicolemarsaglia changed the title Add zero copy for uints & ints Add device copy for uints & ints Mar 31, 2025
@nicolemarsaglia nicolemarsaglia merged commit 7cb169c into develop Mar 31, 2025
22 checks passed
@nicolemarsaglia nicolemarsaglia deleted the task/2025_03_unsupported_data_type branch March 31, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants