Task/2025 3 27 1428 path enhancements rollup issue fmt path strings #1496
Conversation
…nctionality to expand_family_variable
There was a problem hiding this comment.
This is great!
Can we add some tests for path gen strings in:
https://github.com/Alpine-DAV/ascent/blob/develop/src/tests/ascent/t_ascent_utils.cpp
There we can try for various patterns without a full ascent pipeline execution.
We can also test what happens with mangled pattern (which folks will give us)
A new place where we need path expansion in the legacy vtk extract:
For the family case, we should think about how to handle if the file exists on disk.
That is the case we want to check only with rank 0.
I think s_file_family_map will be the same on all tasks for our use cases.
| std::smatch match; | ||
| std::string result_string = path_string; | ||
|
|
||
| std::regex valid_int_format(R"(^\d*d$)"); |
There was a problem hiding this comment.
these look good to me, as a gift to our future selves, can you add a comment about the types of patterns these will catch?
…ine as the if/for statements
…ng files with matching names to determine a minimum family value
…-3-27_1428-path-enhancements-rollup-issue_fmt-path-strings
|
@cyrush I think I have addressed all your feedback but this is still a WIP:
Outstanding:
|
| std::regex search_pattern(search_pattern_str); | ||
|
|
||
| // Checking the directory contents for any filenames that match | ||
| std::vector<std::string> contents; |
There was a problem hiding this comment.
we only want to check the dir contents on rank 0
There was a problem hiding this comment.
I opted to protect that entire chunk where contents is used for just rank 0 and then afterwords I broadcast the updated family value. Alternatively, I could set the contents variable and then pass that into a conduit node and broadcast that node. Let me know if you want me to make that change :)
| return result_string; | ||
| } | ||
|
|
||
| int check_directory_for_family_value(const std::string& path_string, int family_value) { |
There was a problem hiding this comment.
we should pass int mpi_comm_id id here.
We can use a strategy like this to handle mpi vs non mpi:
| } | ||
|
|
||
| std::string expand_path_special_variables(const std::string &path_string, | ||
| int counter, |
There was a problem hiding this comment.
we may have to pass mpi comm here as well
No description provided.