-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port of #71984- Fix for arrayWithConstant size estimation using row's element size #631
Port of #71984- Fix for arrayWithConstant size estimation using row's element size #631
Conversation
Removed a typo
Move Cancel workflow to GitHub runners
Updated the README, security policy, issue templates, and other details
Scheduled runs
…using row's element size
@MyroTk apologies for tagging you but can you please take a look? Thanks! |
Hi @onkar ! Thank you for contribution! We have a bit more complex workflow here, comparing to upstream, and basically we don't merge anything into master.
Or I can do it for you |
Hello @Enmk, I would like the fix released in the upcoming 24.8 version. We saw this in internal testing and it would be nice to resolve that issue after the upgrade. Please change the PR's base for me. Thank you for taking a look! |
@Enmk, I am running into unrelated merge conflicts after changing the base branch to customizations/24.8.14. Can you please help with the next steps? I tried opening #642 directly on the branch but that did not help. |
Please figure out conflict in |
closed in favor of #650 |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Port of ClickHouse#71894 from ClickHouse upstream. While upgrading to Altinity's version 24.8.11.51285, we started seeing this issue. After doing a bit of digging, it appears that ClickHouse#71894 is missing from the
master
branch.Documentation entry for user-facing changes
Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: