Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add namespace override capability for multi-namespace deployments #1640

Open
wants to merge 1 commit into
base: 0.25.0
Choose a base branch
from

Conversation

bwdmr
Copy link

@bwdmr bwdmr commented Feb 17, 2025

Adds a new helper template "altinity-clickhouse-operator.namespace" that allows overriding the release namespace via Values.namespaceOverride. Updates all resource templates to use this helper instead of directly referencing .Release.Namespace. This change enables multi-namespace deployments in combined charts while maintaining backward compatibility.

Thanks for taking the time to contribute to clickhouse-operator!

Please, read carefully instructions on how to make a Pull Request.

This will help a lot for maintainers to adopt your Pull Request.

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

@Slach Slach self-requested a review February 17, 2025 09:32
Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look to dev/generate_helm_chart.sh

all templates/generated shall be changed from this script

@bwdmr bwdmr force-pushed the namespaceoverride branch from db20c8a to 7c412fb Compare February 21, 2025 06:24
…loyments

Adds a new helper template "altinity-clickhouse-operator.namespace" that allows
overriding the release namespace via Values.namespaceOverride. Updates all
resource templates to use this helper instead of directly referencing
.Release.Namespace. This change enables multi-namespace deployments in combined
charts while maintaining backward compatibility.
@bwdmr bwdmr force-pushed the namespaceoverride branch from 7c412fb to 3aa503c Compare February 21, 2025 06:27
@Slach Slach changed the base branch from master to 0.25.0 February 21, 2025 07:27
@Slach
Copy link
Collaborator

Slach commented Feb 21, 2025

Sorry for disturbing you again

Could you clarify?
What is the goal for these changes?

Do you want to install helm chart to some namespace but install rendered manifest to another namespace?
Why?

Which behavior you try to achieve?

If you want to change operator watched namespace for example and install operator in one namespace but watch custom resources in another namespaces

just change values.yaml

  files:
    config.yaml:
      # empty value will watch all namespaces
      namespaces: [""]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants