Update coach.xml recordComplete with new fieldname #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix broken field reference with Salesforce due to my stupid change without checking dependencies. In this file corrected reference to Contact field is now Contact__r.Student_Record_Complete__c The internal StudentIncompleteRecord is unchanged so its meaning and the logic of the field no longer makes sense without some changes to the UI. I made the default to FALSE (instead of TRUE) so at least its more likely to update correct. Next Step: Change the wording in the UI, then if necessary, underlying logic
CritiqalPete
added
bug
|
Fully addressed in #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix broken field reference with Salesforce due to my stupid change without checking dependencies.
In this file corrected reference to Contact field is now Contact__r.Student_Record_Complete__c
The internal StudentIncompleteRecord is unchanged so its meaning and the logic of the field no longer makes sense without some changes to the UI.
I made the default to FALSE (instead of TRUE) so at least its more likely to update correct.
Next Step: Change the wording in the UI, then if necessary, underlying logic