-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oct 27, 2024: Sandbox to Production #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/209 GET /enrollments/{enrollmentId}
- Return the whole record on creation - Set `Incomplete_Record__c` as true if a student was registered
Step 1 Update: - Replace a separate Salesforce Query with flow-ref to the existing GET Contact endpoint Step 2, Step 3: - Include updated record in the response ('data' field) Other: - Include `Incomplete_Record_c` to GET Contact Query
- Created a new flow: `post:\contacts\(contactId)\finishRegistration:application\json:salesforce-data-api-config` - Added the flow to RAML - Added the flow and testing information to Postman - Modified POST WaiverID to support incoming flow references
- Execute PATCH flow instead of updating the field in the code (Step 4) - Modify PATCH flow to support the new call - Return `IncompleteRecord ` instead of `Incomplete_Record__c` - Add WaiverHistory to the response (step 4) - Add Postman Collection for future tests
…-support Local Run Support + Script To Build the App Locally
…r-the-updated-web-registration Feat/265 support for the updated web registration
…SCORESBayArea/salesforce-data-api into feat/260-cicd-deployment
…-production-2 CI/CD Deployment: Production
…orTeams Fix/252 Updated RAML for /teams based on acceptance criteria
…orContacts Fix/250 Updated RAML for /contacts based on acceptance criteria
Verified RAML `/coach` endpoints
1) Waivers are filtered by "Archieved__c" 2) Removed "PaperReceived" variable (it should not be here)
- Replaced `Paper_Form_Received__c` with `Signed_Paper_Form_Received__c`
Example: {{base_url}}/waiverHistory?contactId=003UQ00000GXyAfYAL
Update Postman Collection for `/coach` endpoints
…onversation with Pete
…complete2 Fix: `Incomplete_Record__c` -> `Student_Record_Complete__c`
…er-history Fixes for Waiver (get, post) and new endpoint for WaiverHistory
CritiqalPete
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a brief check. please test after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.