-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production: Updated Global Error Handler + Enabling Validations #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for the older editor AnypointStudio
… Slack Important note 1. New .properties variables are required: - slack.client_id - slack.client_secret - slack.enabled 2. `global.xml` is now universal, no need to rename files on deployment
- APIKIT:BAD_REQUEST (400) - APIKIT:METHOD_NOT_ALLOWED (405) - APIKIT:NOT_ACCEPTABLE (406) - APIKIT:NOT_FOUND (404) - APIKIT:UNSUPPORTED_MEDIA_TYPE (415) - STREAM_MAXIMUM_SIZE_EXCEEDED (413) - SLACK:BAD_REQUEST, SLACK:CLIENT_ERROR, SLACK:CONNECTIVITY, SLACK:INTERNAL_SERVER_ERROR, SLACK:NOT_ACCEPTABLE, SLACK:NOT_FOUND, SLACK:RETRY_EXHAUSTED, SLACK:SERVER_ERROR, SLACK:SERVICE_UNAVAILABLE, SLACK:TIMEOUT, SLACK:TOO_MANY_REQUESTS, SLACK:UNAUTHORIZED, SLACK:UNSUPPORTED_MEDIA_TYPE (500) - EXPRESSION (500) -
- delete `global.xml.anypoint` - delete `disable-validations.sh.old` (from now, validations will be enabled on production) - add Slack secrets during deployment (through GitHub secrets)
1) Separate the error message into two: main and additional in the thread 2) Improve timestamp readability & switch to SF timezone 3) Add "Origin" to keep track of where requests come from
`slack.enabled` `slack.client_id` `slack.client_secret` (secure)
…ng-slack-integration Updated Global Error Handler: Slack Integration
CritiqalPete
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the update global error handler described in the recent Sandbox PR, as well as small fixes:
Very important - this PR enables RAML-based validation‼️
After approximately 6 months of testing in the Sandbox environment, we are now enabling validation of requests based on RAML files. There is a possibility that some rarely used frontend functionalities may either send incorrect requests or that the related RAML files are misconfigured. In such cases, I can apply a quick patch (within 24 hours) or we can immediately roll back to the previous server version.