Skip to content

timer: call list.start regardless new or not - #1

Open
Aminadav wants to merge 1 commit into
Aminadav:masterfrom
abbr:fix-issue-timer-master
Open

timer: call list.start regardless new or not#1
Aminadav wants to merge 1 commit into
Aminadav:masterfrom
abbr:fix-issue-timer-master

Conversation

@Aminadav

@Aminadav Aminadav commented Apr 5, 2016

Copy link
Copy Markdown
Owner

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

Description of change

Please provide a description of the change here.

Call start regardless whether list is new
or not to prevent incorrect active_handles
count.

Fixes nodejs/node-v0.x-archive#25831

Call start regardless whether list is new
or not to prevent incorrect active_handles
count.

Fixes nodejs/node-v0.x-archive#25831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect loop->active_handles count when nested setTimeout calls have same value

2 participants