Update filter atts #105
Merged
Update filter atts #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into update-filterAtts
vdegraaf
reviewed
May 3, 2024
apps/admin/src/app/dataProvider.ts
Outdated
Comment on lines
25
to
40
| export const dataProvider: DataProvider = { | ||
| ...baseDataProvider, | ||
| update: (resource, params) => { | ||
| // 'form' updates use PUT requests, all other updates use PATCH requests | ||
| if (resource === 'form') { | ||
| return fetchJson(`http://localhost:8000/${resource}/${params.id}`, { | ||
| method: 'PUT', | ||
| body: JSON.stringify(params.data), | ||
| }).then(({ json }) => ({ data: json })) | ||
| } | ||
| return fetchJson(`http://localhost:8000/${resource}/${params.id}`, { | ||
| method: 'PATCH', | ||
| body: JSON.stringify(params.data), | ||
| }).then(({ json }) => ({ data: json })) | ||
| }, | ||
| } |
There was a problem hiding this comment.
I think this can use a test.
There was a problem hiding this comment.
Good point. And maybe /app is not the right location for the data provider? Shall I move it to /admin/Admin?
There was a problem hiding this comment.
Wouldn't put it in a component. Maybe a /service folder with these kind of functions for now?
There was a problem hiding this comment.
It will only ever be used in the Admin component though. Having it in /service makes it harder to find imo.
There was a problem hiding this comment.
Alright, let's do that for now. We can always rearrange.
vdegraaf
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meldingen
This PR sets up our use of panel components. Forms are now automatically built as wizards, and the
panelcomponent attrs are added tofilterAttributes.This also changes the update requests to PATCH, except for update requests to the 'form' endpoint. That still uses PUT.