Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Summary page #727

Merged
merged 23 commits into from
Feb 20, 2025
Merged

Add Summary page #727

merged 23 commits into from
Feb 20, 2025

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Feb 18, 2025 •
edited by jira bot
Loading

Meldingen

Ticket: SIG-6360

Before opening a pull request, please ensure:

  • Double-check your branch is based on main and targets main
  • Code is well-commented, linted and follows project conventions

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

@alimpens alimpens requested a review from vdegraaf February 18, 2025 12:57
vdegraaf
vdegraaf reviewed Feb 20, 2025
View reviewed changes
apps/public/src/app/(general)/samenvatting/_utils/getSummaryData.ts Outdated
melding: MeldingOutput
primaryFormLabel: string
additionalQuestionsAnswers: GetMeldingByMeldingIdAnswersResponse
location: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Location can be undefined.

@alimpens alimpens enabled auto-merge (squash) February 20, 2025 16:24
@alimpens alimpens merged commit c830e10 into main Feb 20, 2025
3 checks passed
@alimpens alimpens deleted the 6360-add-summary-page branch February 20, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdegraaf vdegraaf vdegraaf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alimpens @vdegraaf