Get Contact page question labels and descriptions from back-end #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdegraaf
reviewed
Mar 4, 2025
Comment on lines
23
to
27
| const textareaComponents = | ||
| primaryForm?.filter((component): component is StaticFormTextAreaComponentOutput => component.type === 'textarea') || | ||
| [] | ||
|
|
||
| return <Home formData={textareaComponents} /> |
There was a problem hiding this comment.
What is happening here? And why is this necessary?
Comment on lines
4
to
6
| import { Grid, SubmitButton } from '@meldingen/ui' | ||
| import { useActionState } from 'react' | ||
|
|
There was a problem hiding this comment.
We didn't set a test coverage limit, but branches of this component are at 77% since the airadescribedby is not tested.
…into get-static-form-texts-from-be
vdegraaf
reviewed
Mar 10, 2025
Comment on lines
23
to
25
| return ( | ||
| <Grid paddingBottom="large" paddingTop="medium"> | ||
| <Grid.Cell span={{ narrow: 4, medium: 6, wide: 6 }} start={{ narrow: 1, medium: 2, wide: 3 }}> |
There was a problem hiding this comment.
This component needs internationalisation
There was a problem hiding this comment.
Yup. I didn't do that yet to prevent merge conflicts.
Co-authored-by: Vincent de Graaf <[email protected]>
Co-authored-by: Vincent de Graaf <[email protected]>
vdegraaf
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.